Fix compilation issue on LTS due to changes in NearestNeighbors (NN) API#77
Merged
mkborregaard merged 5 commits intoEcoJulia:mainfrom Jan 29, 2026
Merged
Fix compilation issue on LTS due to changes in NearestNeighbors (NN) API#77mkborregaard merged 5 commits intoEcoJulia:mainfrom
mkborregaard merged 5 commits intoEcoJulia:mainfrom
Conversation
Collaborator
Author
|
@mkborregaard I've also brought the julia github actions to their latest versions |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 88.23% 88.39% +0.15%
==========================================
Files 19 19
Lines 476 491 +15
==========================================
+ Hits 420 434 +14
- Misses 56 57 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@mkborregaard - just a bump, this is ready to merge afaict |
Member
|
Sorry, I had missed this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the pull request does
A change in
NL(always_falseas an export was replaced byReturns(false)broke precompilation.Fixes #76
This has been fixed by creating a global variable
always_false = Returns(false). IfNNexportsalways_false, this one is used instead. The later is important as previous versions ofNNmay not handleReturns(false). This results in no change to the package code.Type of change
Checklist
Project.tomlfieldversionhas been updated